BLD: Implement PEP639 licensing #28982
Conversation
c0baa2f to
d81ddb8
Compare
d81ddb8 to
50cc2e7
Compare
This allows developers to test out the build locally. With this, I was able to fix the test command by setting `PIP_PREFER_BINARY` to avoid re-building Pillow, which accidentally dropped manylinux2014 wheels in the latest release: python-pillow/Pillow#9057 Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn't seem to be a valid setting. Thus I have dropped the `twine check`, which only tests the `README` rendering and so checking the sdist is sufficient. Additionally, I have commented out the license check, as we cannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
231a093 to
8344c33
Compare
This allows developers to test out the build locally. With this, I was able to fix the test command by setting `PIP_PREFER_BINARY` to avoid re-building Pillow, which accidentally dropped manylinux2014 wheels in the latest release: python-pillow/Pillow#9057 Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn't seem to be a valid setting. Thus I have dropped the `twine check`, which only tests the `README` rendering and so checking the sdist is sufficient. Additionally, I have commented out the license check, as we cannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
|
Note, this is now working, I think, but it would require meson-python 0.18, which was only released in April of this year, and Meson 1.6, released October last year. |
|
This is looking pretty good to me.
I wouldn't worry about that, using recent build dependencies is almost never a problem. The more relevant constraint is that this drops support for older |
|
I'm not sure if that's a problem; I used pip 24.3.1 to install from this branch and from the wheels generated in CI without any issues. |
|
Hmm interesting. The wheels do contain |
I verified this now all the way back to |
This allows developers to test out the build locally. With this, I was able to fix the test command by setting `PIP_PREFER_BINARY` to avoid re-building Pillow, which accidentally dropped manylinux2014 wheels in the latest release: python-pillow/Pillow#9057 Note also that we previously set `CIBW_AFTER_BUILD`, but this doesn't seem to be a valid setting. Thus I have dropped the `twine check`, which only tests the `README` rendering and so checking the sdist is sufficient. Additionally, I have commented out the license check, as we cannot do multiple licenses with meson-python without PEP639 (matplotlib#28982).
8344c33 to
ca3d9da
Compare
PR summary
Note that this would require meson-python 0.18.0, which was only released in May 2025, so we may not want to include this just yet.
It does fix the issue that that wheels do not include all licenses that we have in the sdist. Because of some discussion about the dynamicity of the license(-files) key, it does not automatically include the licenses of subprojects.
PR checklist