DOC: Update missing references for numpydoc 1.8.0#28718
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Aug 14, 2024
Merged
DOC: Update missing references for numpydoc 1.8.0#28718timhoffm merged 1 commit intomatplotlib:mainfrom
timhoffm merged 1 commit intomatplotlib:mainfrom
Conversation
The numpydoc 1.8.0 release re-ordered some sections [1] in generated docs, which caused our missing reference extension to no longer ignore some entries since they are at different lines. Fixes matplotlib#28715 [1] numpy/numpydoc#571
Member
Author
|
As a side note, this doesn't fail on the |
story645
approved these changes
Aug 14, 2024
Member
story645
left a comment
There was a problem hiding this comment.
I'm assuming failing tests are unrelated?
Member
Author
|
That's a change in pybind11, which is unfortunately my fault: pybind/pybind11#5300 (comment) |
timhoffm
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The numpydoc 1.8.0 release re-ordered some sections [1] in generated docs, which caused our missing reference extension to no longer ignore some entries since they are at different lines.
Fixes #28715
[1] numpy/numpydoc#571
PR checklist