[TST] Adjust tests to be more tolerant to floating point math operations being imprecise#25813
Merged
oscargus merged 1 commit intomatplotlib:mainfrom May 6, 2023
Merged
Conversation
…ons being imprecise Two cases of projections having degenerate points where the edge case is inherently unstable, one case of attempting to do equality checks on processed floats
Member
Author
|
Not sure why azure didn't run here (I was initially hoping that our tk/macos azure image problems were resolved when I saw a green checkmark instead of a red X, but no, no azure at all here...) |
Member
|
(because all floats except sums of powers of two, the power differing at most 53 are) |
tacaswell
approved these changes
May 5, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 6, 2023
…to floating point math operations being imprecise
QuLogic
added a commit
that referenced
this pull request
May 6, 2023
…813-on-v3.7.x Backport PR #25813 on branch v3.7.x ([TST] Adjust tests to be more tolerant to floating point math operations being imprecise)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #25789, see there for detailed discussion of what changed
This is addressing the extremely small (literally Unit of Least Precision, ULP) changes to how numpy computes sin/cos on main.
Through a combination of ratios of small numbers and relying on precise edge case behavior in tests of floats, we saw 3 cases where the miniscule difference compounded to test failures.
Two cases of projections having degenerate points where the edge case is inherently unstable:
one case of attempting to do equality checks on processed floats:
PR checklist