Use repr in error message Addresses #21959#24403
Merged
QuLogic merged 6 commits intomatplotlib:mainfrom Nov 10, 2022
Merged
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
QuLogic
reviewed
Nov 9, 2022
story645
approved these changes
Nov 9, 2022
QuLogic
reviewed
Nov 9, 2022
QuLogic
approved these changes
Nov 10, 2022
Member
|
Do you mind if I squash merge this PR, or would you like to? |
Contributor
Author
|
feel free to squash, sir. thanks for your help. |
Member
|
Thanks @jefromyers! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Closed
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Dec 19, 2022
* use repr in error message closes matplotlib#21959 * add test for repr error message * fix formatting * clean up formatting and naming * add `pragma: no cover` * remove import and function name a bit more explicit
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposed solution in issue #21959. Error message now outputs the user’s input via
repr.Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst