Fix centre square rectangle selector part 1#21604
Merged
timhoffm merged 5 commits intomatplotlib:mainfrom Nov 14, 2021
Merged
Conversation
… existing shape, part 1, with centering on
… existing shape, part 2, with centering off
dstansby
reviewed
Nov 11, 2021
Member
dstansby
left a comment
There was a problem hiding this comment.
Looks good overall - I've left a few suggestions and questions.
ericpre
commented
Nov 11, 2021
Member
Author
ericpre
left a comment
There was a problem hiding this comment.
Thanks, all comments should have been addressed!
dstansby
approved these changes
Nov 12, 2021
Member
dstansby
left a comment
There was a problem hiding this comment.
Thanks - all looks good to me!
Member
|
I think this is a bugfix, so going to milestone to 3.5.x - second reviewer feel free to correct me on this. |
Member
Author
timhoffm
approved these changes
Nov 14, 2021
Comment on lines
+2973
to
+2974
| size_on_press = [x1 - x0, y1 - y0] | ||
| center = [x0 + size_on_press[0] / 2, y0 + size_on_press[1] / 2] |
Member
There was a problem hiding this comment.
I would use tuples instead of lists for coordinates.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 14, 2021
dstansby
added a commit
that referenced
this pull request
Nov 15, 2021
…604-on-v3.5.x Backport PR #21604 on branch v3.5.x (Fix centre square rectangle selector part 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dstansby, as mentioned in #20839 (comment), this is the first part of #20839.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.