Skip to content

Add GHA testing whether files were added and deleted in the same PR.#21359

Merged
timhoffm merged 1 commit intomatplotlib:masterfrom
anntzer:cleanpr
Oct 15, 2021
Merged

Add GHA testing whether files were added and deleted in the same PR.#21359
timhoffm merged 1 commit intomatplotlib:masterfrom
anntzer:cleanpr

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Oct 14, 2021

PR Summary

Currently has two extra commits that test the functionality and should fail the workflow. Will remove these commits once we know this works.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer force-pushed the cleanpr branch 9 times, most recently from 940ffb9 to cdc9e73 Compare October 14, 2021 21:21
timhoffm
timhoffm approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Can we make the message stand out more? It's a bit burried between the other output:

grafik

Maybe add ------------ lines above and below? Or do you have a better idea?

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Oct 14, 2021

I removed the other output.
I don't think it's worth overengineering this, as we don't expect this to fail so often :-) But if you have a better solution, feel free to push it.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Oct 14, 2021

You can print out a special message which executes a workflow command, creating an annotation. I'm not sure how it looks if the annotation is on a file that is subsequently deleted.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Oct 14, 2021 •
edited
Loading

I'm not sure I really want to try (and loop over lines in bash, which I never remember how to do :-)), but you should feel free to do so :-)

jklymak
jklymak approved these changes Oct 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful!

@timhoffm
Copy link
Copy Markdown
Member

timhoffm commented Oct 15, 2021

@anntzer this is ready. Please remove the test commits.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Oct 15, 2021

Done.

@timhoffm timhoffm merged commit 5a99a60 into matplotlib:master Oct 15, 2021
@timhoffm
Copy link
Copy Markdown
Member

timhoffm commented Oct 15, 2021

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 15, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21359: Add GHA testing whether files were adde…
a1c33dd 
…d and deleted in the same PR.
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 15, 2021
Merged
@timhoffm timhoffm added this to the v3.5.0 milestone Oct 15, 2021
jklymak added a commit that referenced this pull request Oct 15, 2021
@jklymak
Merge pull request #21367 from meeseeksmachine/auto-backport-of-pr-21…
aed0ec6 
…359-on-v3.5.x

Backport PR #21359 on branch v3.5.x (Add GHA testing whether files were added and deleted in the same PR.)
@anntzer anntzer deleted the cleanpr branch October 15, 2021 11:16
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@timhoffm
Merge pull request #21359 from anntzer/cleanpr
704b855 
Add GHA testing whether files were added and deleted in the same PR.
@anntzer anntzer mentioned this pull request Nov 10, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anntzer @QuLogic @timhoffm @jklymak