Prefer warn_deprecated instead of warnings.warn.#11297
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Jul 1, 2018
Merged
Prefer warn_deprecated instead of warnings.warn.#11297timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
4d94f3d to
d3d9fad
Compare
jklymak
approved these changes
May 31, 2018
Member
jklymak
left a comment
There was a problem hiding this comment.
This seems good to me so long as you caught all the warnings associated w/ deprecations....
timhoffm
approved these changes
Jun 2, 2018
Member
timhoffm
left a comment
There was a problem hiding this comment.
Not sure why Travis OSX is failing. Seems unrelated.
warn_deprecated has the advantage of always listing the deprecation version and removal version. Hopefully, in the future it will also be able to set the stacklevel more systematically. Redesign the way deprecation of rcParams is done to make it use warn_deprecated. Merge obsolete_set into deprecated_ignore_map as they are semantically similar, it's just that there's no alternative rcParam for obsolete_set. Rename deprecated_set to deprecated_remain_as_none as the former name really doesn't say anything about the deprecation semantics. text.dvipnghack and axes.hold should be completely removed but that'll be another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warn_deprecated has the advantage of always listing the deprecation
version and removal version. Hopefully, in the future it will also be
able to set the stacklevel more systematically.
Redesign the way deprecation of rcParams is done to make it use
warn_deprecated. Merge obsolete_set into deprecated_ignore_map as they
are semantically similar, it's just that there's no alternative rcParam
for obsolete_set. Rename deprecated_set to deprecated_remain_as_none as
the former name really doesn't say anything about the deprecation
semantics.
text.dvipnghack and axes.hold should be completely removed but that'll
be another PR.
PR Summary
PR Checklist