Merged
Conversation
This change should have no effect on any plot, but it avoids warnings that can arise when an inf occurs under a mask.
Previously, although vmin, vmax could be specified manually in a norm used to initialize a ContourSet, the values would be used only if both were specified. Now one can set either or both of vmin, vmax in the norm, and they will take precedence over the default.
This changeset also simplifies and clarifies the vmin, vmax explanation and handling for pcolor and pcolormesh.
Member
|
Looks good. I think this also fixes #1046. |
…ntour Formerly, colorbar would not place ticks at contour levels outside the vmin-vmax range, and would not add line contour marks at such levels.
Member
Author
|
I added some related colorbar changes and a test. That's all I have in mind for this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes follow #1022 by fixing a baseline image, adding to the CHANGELOG entry, and making the contour handling of norm scaling more consistent with other image-like plotting such as pcolor by adding vmin, vmax kwargs.