Optimize compilation of /./ when "u" is not enabled#29
Merged
mathiasbynens merged 3 commits intomathiasbynens:masterfrom Sep 13, 2019
Merged
Optimize compilation of /./ when "u" is not enabled#29mathiasbynens merged 3 commits intomathiasbynens:masterfrom
mathiasbynens merged 3 commits intomathiasbynens:masterfrom
Conversation
nicolo-ribaudo
added a commit
to nicolo-ribaudo/regexpu-fixtures
that referenced
this pull request
Sep 11, 2019
This was referenced Sep 11, 2019
nicolo-ribaudo
commented
Sep 11, 2019
nicolo-ribaudo
commented
Sep 11, 2019
mathiasbynens
pushed a commit
to mathiasbynens/regexpu-fixtures
that referenced
this pull request
Sep 12, 2019
mathiasbynens
approved these changes
Sep 12, 2019
Collaborator
Author
|
Oh I just found a regression: rewritePattern('a.')throws. It's a bug with regjsgen: https://runkit.com/embed/yg6wt7r7e2nt |
This was referenced Sep 20, 2019
Owner
|
Looks like the affected tests in regexpu were never updated? |
Owner
Collaborator
Author
|
Thanks! I totally forgot about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (partially) #24
Travis is failing because it needs mathiasbynens/regexpu-fixtures#1