Skip to content

Support python3.13#4100

Closed
DanielYang59 wants to merge 67 commits intomaterialsproject:masterfrom
DanielYang59:support-python313
Closed

Support python3.13#4100
DanielYang59 wants to merge 67 commits intomaterialsproject:masterfrom
DanielYang59:support-python313

Conversation

@DanielYang59
Copy link
Copy Markdown
Contributor

@DanielYang59 DanielYang59 commented Oct 10, 2024 •
edited
Loading

Summary

Optional dependencies that miss Python 3.13 support:

  • openff-toolkit (conda source)
  • chgnet

@DanielYang59 DanielYang59 mentioned this pull request Oct 10, 2024
Closed
@DanielYang59 DanielYang59 mentioned this pull request Oct 10, 2024
Merged
@DanielYang59
Copy link
Copy Markdown
Contributor Author

DanielYang59 commented Oct 10, 2024

might close this one now as too many packages don't support python 3.13, feel free to take over this

@ml-evs ml-evs mentioned this pull request Oct 28, 2024
Merged
@DanielYang59 DanielYang59 reopened this Nov 19, 2024
DanielYang59
DanielYang59 commented Nov 19, 2024
View reviewed changes
@DanielYang59 DanielYang59 force-pushed the support-python313 branch 2 times, most recently from 38a70c4 to d1694e3 Compare November 19, 2024 13:43
@DanielYang59 DanielYang59 mentioned this pull request Feb 14, 2025
Merged
@DanielYang59
Copy link
Copy Markdown
Contributor Author

DanielYang59 commented Feb 14, 2025 •
edited
Loading

I'm pretty much stuck with the Windows runner failure, help needed

shyuep pushed a commit that referenced this pull request Feb 18, 2025
@DanielYang59
Migrate some type annotation tweaks from #4100 (#4290)
5aff054 
* add types for analysis.eos

* add requires decorator to is_valid_bibtex

* revert adding requires

* fix typo in core.structure.rotate_sites

* skip prototype test if pybtex is not available

* remove import guard from cherry pick
@DanielYang59
Copy link
Copy Markdown
Contributor Author

DanielYang59 commented Apr 17, 2025

Would close this and open a new PR once #4361 is merged, this PR has been around for too long and I cannot remember everything here (plus most changes are related to pybtex)

@DanielYang59 DanielYang59 deleted the support-python313 branch April 17, 2025 20:00
@DanielYang59 DanielYang59 mentioned this pull request Apr 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python 3.13 support

2 participants

@DanielYang59 @shyuep