Add a CI run that only tests non-optional deps (optimistically)#3759
Closed
ml-evs wants to merge 1 commit intomaterialsproject:masterfrom
Closed
Add a CI run that only tests non-optional deps (optimistically)#3759ml-evs wants to merge 1 commit intomaterialsproject:masterfrom
ml-evs wants to merge 1 commit intomaterialsproject:masterfrom
Conversation
|
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Contributor
Author
|
@CodeRabbit disable |
9 tasks
- Hopefully all tests have been written in such a way that they will be skipped if the underlying required package is not found
fa78941 to
783ba88
Compare
Contributor
Author
|
Superseded by #3857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of #3646.
This PR adds a separate test suite run for the case that only mandatory dependencies have been installed (directly via
pip install -e .[dev]), attempting to mimic what a user will actually have when they justpip install pymatgen. This will then hopefully catch errors where either optional imports are not properly guarded, or main functionality is rendered broken by optional dependency updates.Not sure if this is something that you would actually want to merge given the potential maintenance overhead, but this might be able to spot more issues before they arise now that #3757 is merged.
Someone will need to carefully look at how I am invoking the tests, as I'm not sure if there is any coverage/durations magic going on that needs to be separated between the two runs (the comments to that effect at the top of
test.ymlmight now be out of date).