Skip to content

Add CI run without 'optional' deps installed#3857

Merged
janosh merged 9 commits intomasterfrom
ci-only-required-deps
Jun 3, 2024
Merged

Add CI run without 'optional' deps installed#3857
janosh merged 9 commits intomasterfrom
ci-only-required-deps

Conversation

@janosh
Copy link
Copy Markdown
Member

@janosh janosh commented Jun 3, 2024

addresses the underlying cause of why the issue reported by @kavanase in #3752 (comment) was only caught after pypi release

…xtras: '' to test pymatgen without any optional deps installed
@janosh janosh added tests Issues with or changes to the pymatgen test suite ci Continuous integration pkg Package health and distribution related stuff ecosystem Concerning the larger pymatgen ecosystem labels Jun 3, 2024
@janosh janosh requested review from mkhorton and shyuep as code owners June 3, 2024 17:11
@janosh janosh changed the title Add CI run to test pymatgen without any 'optional' deps installed Add CI run without 'optional' deps installed Jun 3, 2024
f-strings, better var names, fix ruff RUF002
@janosh janosh requested a review from Andrew-S-Rosen as a code owner June 3, 2024 19:02
@janosh janosh enabled auto-merge (squash) June 3, 2024 19:03
@janosh janosh merged commit d1fac20 into master Jun 3, 2024
@janosh janosh deleted the ci-only-required-deps branch June 3, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration ecosystem Concerning the larger pymatgen ecosystem pkg Package health and distribution related stuff tests Issues with or changes to the pymatgen test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant