This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(toolbar): Adjusting sibling elements on mobile landscape#846
Merged
yeelan0319 merged 1 commit intomaterial-components:masterfrom Jun 23, 2017
mikegleasonjr:master
Merged
fix(toolbar): Adjusting sibling elements on mobile landscape#846yeelan0319 merged 1 commit intomaterial-components:masterfrom mikegleasonjr:master
yeelan0319 merged 1 commit intomaterial-components:masterfrom
mikegleasonjr:master
Conversation
yeelan0319
approved these changes
Jun 23, 2017
Contributor
|
Thanks @MichaelTamm for fixing the bug :) |
Contributor
Author
|
My pleasure. Will try to contribute more since it is pretty easy to do with you guys. |
lynnmercier
pushed a commit
that referenced
this pull request
Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the fix there is a gap when hitting
@media (max-width: 959px) and (orientation: landscape):Because the row height is changed on that breakpoint:
https://github.com/material-components/material-components-web/blob/master/packages/mdc-toolbar/mdc-toolbar.scss#L48