Add notification policies and notification requests#29366
Conversation
5e628d8 to
183d00b
Compare
728af2b to
436c814
Compare
35a5501 to
0b486d8
Compare
ClearlyClaire
left a comment
There was a problem hiding this comment.
I really like the idea but I'm very worried that must_be_following_dm is gone with no equivalent. I really do think Private Mentions warrant their own filter condition.
Otherwise, this looks good, but I have left a few inline comments.
5dbb26a to
cfd1f2b
Compare
ClearlyClaire
left a comment
There was a problem hiding this comment.
This looks good overall, and I'm happy the Private Mention filter is back in some form!
I have a few concerns still:
- I think we should preserve the current settings for existing users as much as possible, since changes will be unexpected and possibly disruptive, especially for people who use apps that won't immediately handle the filtered notification settings
- is dismissing notification requests intended to dismiss them forever? If so, we should probably clean up and avoid creating new notifications for dismissed requests, as well as provide a way to undo the action, as is currently possible with mutes. If not, that needs to be changed.
86e01b0 to
5db7ade
Compare
|
I added a way to retrieve dismissed notification requests in the API. The accept method does not require the request to not be dismissed, so dismissed requests could still be accepted by the user if they change their mind. |
5db7ade to
cf6a8e3
Compare
cf6a8e3 to
41d99af
Compare
renchap
left a comment
There was a problem hiding this comment.
I did not review this, but all the previous comments have been addressed.
Let's merge this, and another PR if some things needs to be adjusted.
|
I see that this does not edit any UI elements, is there a PR somewhere which will add these? 👀 |
|
Yes, #29433 |
|
Hello, I contribute to the Tusky project. I do not find (or am I just missing it?) the four new endpoints in the API page https://docs.joinmastodon.org/api/ , and the notes above are not sufficient to implement support for this feature (what payload does When can we expect a full documentation of this feature? If content is being hidden from third party clients unless they implement a feature which is only documented as Ruby source, that is problematic. |
|
Yes, we have an internal ticket to add API documentation for this. |
In #29366, it was intended that notifications from limited non-followed users would end up in filtered notifications instead of being outright dropped. However, those notifications were still dropped in an earlier check.
Allow users to set a policy for who they want to see notifications from. The rest appear as notification requests that can be perused and accepted separately.
Instead of silently dropping messages from limited accounts, filter them and allow users to peruse them as notification requests, even if the user has no policy to filter notifications set.
REST API:
GET /api/v1/notifications/requestsPOST /api/v1/notifications/requests/:id/acceptPost /api/v1/notifications/requests/:id/dismissGET|PUT /api/v1/notifications/policyFixes MAS-39, fixes #12181, fixes #28429, fixes #24117