Return domain block digests from admin domain blocks API#29092
Merged
ClearlyClaire merged 1 commit intomastodon:mainfrom Feb 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29092 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 1058 1058
Lines 28281 28283 +2
Branches 4538 4538
=======================================
+ Hits 24040 24042 +2
Misses 3078 3078
Partials 1163 1163 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Feb 6, 2024
80 tasks
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Feb 27, 2024
ThisIsMissEm
added a commit
to ThisIsMissEm/mastodon-documentation
that referenced
this pull request
Mar 12, 2024
When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior. I've also documented the `digest` property which was added in mastodon/mastodon#29092
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Mar 19, 2024
andypiper
pushed a commit
to mastodon/documentation
that referenced
this pull request
May 7, 2024
* Update admin/domain_blocks to include conflict response When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior. I've also documented the `digest` property which was added in mastodon/mastodon#29092 * Document digest in Admin DomainBlock Entity
ClearlyClaire
pushed a commit
that referenced
this pull request
May 10, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
May 10, 2024
Merged
ClearlyClaire
pushed a commit
that referenced
this pull request
May 16, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
May 17, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
May 17, 2024
This was referenced May 29, 2024
ttrace
pushed a commit
to ttrace/mastodon
that referenced
this pull request
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst developing IFTAS FediCheck, we noticed that the public API for domain blocks
/api/v1/domain_blocksreturns thedigestproperty, but the admin API/api/v1/admin/domain_blocksdid not, which meant we couldn't rely on the domain digest and had to instead match on the domain itself.This adds the digest to the admin domain block serializer, hence adding to the admin domain blocks API