WIP: move the transformations logic into free helper functions#28
Merged
massich merged 2 commits intochange_dig_montage_representationfrom Aug 8, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## change_dig_montage_representation #28 +/- ##
=====================================================================
+ Coverage 89.36% 89.36% +<.01%
=====================================================================
Files 416 417 +1
Lines 75124 75142 +18
Branches 12349 12349
=====================================================================
+ Hits 67133 67151 +18
Misses 5146 5146
Partials 2845 2845 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## change_dig_montage_representation #28 +/- ##
=====================================================================
+ Coverage 89.36% 89.36% +<.01%
=====================================================================
Files 416 417 +1
Lines 75124 75142 +18
Branches 12349 12349
=====================================================================
+ Hits 67133 67151 +18
Misses 5146 5146
Partials 2845 2845 |
5 tasks
massich
added a commit
that referenced
this pull request
Aug 19, 2019
massich
added a commit
that referenced
this pull request
Aug 22, 2019
…6639) * WIP: make transformations private [run CIs] * cosmit and notes * WIP: move transforms This commit corresponds to this PR: #27 * WIP: move the transformations logic into free helper functions (#28) * WIP: Add dig representation * WIP: Remove transforms from __init__ See #29 for details * FIX dictionary unpacking * fix rebase * WIP: Keep dig and chnames only from #30 * fix 052193c * use deprecated property * wip: make point_names private + property * wip: remove deprecation warnings * wip: add ch_names attribute * wip: do not use point_names in __repr__ * wip: remove _get_dig() * wip with alex!!!! * wip: fix wip * fix pep * xxxx: * wip: deprecate compute_dev_head_t * XXX: update XXX comments * wip: add meaningful deprecation message * wip: use new DigMontage constructor * WIP-TST: deprecated DigMontage contruction * TST: use atol for dev_head_t testing * WIP: ADD make_dig_montage (and make it great again) * wip * fix tests * fix test? * don't copy * cleanup * more fixes * fix * fix fieldtrip * FIX: Link * update whatsnew and trigger CIs * use master whatsnew * update the new whatsnew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: move _transform_to_head logic into a free helper function