do not try to update non go files#33
Merged
Merged
Conversation
Only valid go files can be parsed, if you have a project with c files next to the go code the update will fail as it tries to parse all files not just the go ones. Trying to parse a c file fail with "illegal character U+0023 '#'" for example and thus fails the upgrade command. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
1 task
Contributor
Author
|
In order to reproduce the issue we got I can work on a minimal reproducer if wanted. |
marwan-at-work
approved these changes
Oct 24, 2025
Owner
|
Thank you! |
Contributor
Author
|
Thanks for the quick review and merge |
fr12k
pushed a commit
to containifyci/mod
that referenced
this pull request
Nov 2, 2025
Only valid go files can be parsed, if you have a project with c files next to the go code the update will fail as it tries to parse all files not just the go ones. Trying to parse a c file fail with "illegal character U+0023 '#'" for example and thus fails the upgrade command. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only valid go files can be parsed, if you have a project with c files next to the go code the update will fail as it tries to parse all files not just the go ones.
Trying to parse a c file fail with "illegal character U+0023 '#'" for example and thus fails the upgrade command.