modemmanager: Add operator ID and allow to set channels#234
modemmanager: Add operator ID and allow to set channels#234martinpitt merged 2 commits intomartinpitt:mainfrom
Conversation
|
The debian and ubuntu test fail to install packages and the fedora tests fails on ruff in unchanged files (https://github.com/martinpitt/python-dbusmock/actions/runs/15196820126/job/42742834043?pr=234#step:4:825) . |
|
Eek, yeah, the unit tests started failing three weeks ago -- normally I get a notification email for each failure, but I don't any more 🤔 I think I found and fixed that in the notification settings now. I want to fix that first, and then rebase your PR. I sent #235, and will hopefully land it in ~ 30 mins or so. |
martinpitt
left a comment
There was a problem hiding this comment.
This looks good, thanks! A bit sad that this is hard to test, is there perhaps some COPR or so with the new version? I'm happy to add an integration test that pulls in some "git main builds" packages.
| "Channels": dbus.Array([], signature="(uu)"), | ||
| "CellBroadcasts": dbus.Array([], signature="o"), | ||
| } | ||
| modem_cell_broadcast_methods = [ | ||
| ("List", "", "ao", listCbm), | ||
| ("Delete", "o", "", deleteCbm), | ||
| ("SetChannels", "a(uu)", "", setChannels), |
There was a problem hiding this comment.
OK, these match https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/2878833f5c83fe112f579865a6d318ce8413f452
Let's see if the next MM upstream release will break the tests due to changing the output format. I actually wish it did, then we'd have a good reminder to check this new option 😉
There was a problem hiding this comment.
I think it won't. We need to additionally run mmcli -m any --cell-broadcast-status for that so it won't break out of a sudden.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Guido Günther <agx@sigxcpu.org>
|
I pushed a clean rebase to your branch. |
Upstream MM tags dev snapshots every now and then but that didn't happen yet. |
|
@agx Released as https://github.com/martinpitt/python-dbusmock/releases/tag/0.35.0 . Uploading to Fedora and Debian experimental now (due to the release freeze) |
That was quick, thanks a lot! |
The channel setting API is not yet in a released version of ModemManager so I didn't add a
mmclitest.