Skip to content

Conversation

@Gnosnay
Copy link
Contributor

@Gnosnay Gnosnay commented Sep 7, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
New tests added? not needed
Fixed tickets no
License MIT

Description

There is no way to customize the target branch for github uploader. so i add one new text field to check the branch.
I have manually tested it but I dont writes Unit tests for this feature.
This is my first PR in github... so if i have some mistakes in PR process, pls forgive me and tell me how to do that.
thx for your review!

--

Please, don't submit /dist files with your PR!

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 7, 2019

#1327

@Gnosnay Gnosnay closed this Sep 7, 2019
@Gnosnay Gnosnay reopened this Sep 7, 2019
@Jocs
Copy link
Member

Jocs commented Sep 7, 2019

屏幕快照 2019-09-07 下午1 10 59

I think you also need to add the default value, eg master in these three files.

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 7, 2019

@Jocs i considered this question.
with api of octorest lib if u leave branch empty, it will commit for default branch which can be one not master branch...
so the default value is not proper...
how do u think about it?

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 7, 2019

BYW do you know why did the CI fail this time?
i have no.idea about that....:sob:

@Jocs
Copy link
Member

Jocs commented Sep 7, 2019

it will commit for default branch which can be one not master branch...

Yes, if the branch is empty, just delete it as you do, we can give the default value is '', empty string.

@Jocs
Copy link
Member

Jocs commented Sep 7, 2019

BYW do you know why did the CI fail this time?

I think it's due to something wrong with CI when merge PR from other repo other marktext, it's not due to this PR, so we can merge it anyway after review.

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 8, 2019

@Jocs yeah, i have tried it before.
when we use empty string, the rest put failed.
in other words, if you define the branch in payload, u cant define it as empty string, or it will fail.

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 8, 2019

@Jocs i dont get what u mean🤔
i have given branch one default value as '' in view layer in src/ renderer/ prefComponents/ imageUploader/ index. vue🤔.
do u think which is not one proper choice to implement it? do i need to modify the initialisation in another place?

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 8, 2019

and thank you very much for your review and explanation.:stuck_out_tongue_closed_eyes:

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 9, 2019

@Jocs Oh...sorry i missed the pic you pasted before, sorry for that.. i will add it. sorry for that again....

@Gnosnay
Copy link
Contributor Author

Gnosnay commented Sep 9, 2019

@Jocs Sorry.. I received the issue messages with one android app these days, and that app didn't display the pic you pasted ahead... so i didn't get what u mean before.
i have modify the commit and commit message. thx for your review again..

@Jocs
Copy link
Member

Jocs commented Sep 11, 2019

@Yansongsongsong Thanks for your PR, it looks great.

@Jocs Jocs merged commit c52431c into marktext:develop Sep 11, 2019
@Gnosnay Gnosnay deleted the github_uploader_branch branch December 22, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants