-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
add feature: github uploader can customize branch #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Jocs i considered this question. |
|
BYW do you know why did the CI fail this time? |
Yes, if the branch is empty, just delete it as you do, we can give the default value is |
I think it's due to something wrong with CI when merge PR from other repo other marktext, it's not due to this PR, so we can merge it anyway after review. |
|
@Jocs yeah, i have tried it before. |
|
@Jocs i dont get what u mean🤔 |
|
and thank you very much for your review and explanation.:stuck_out_tongue_closed_eyes: |
|
@Jocs Oh...sorry i missed the pic you pasted before, sorry for that.. i will add it. sorry for that again.... |
|
@Jocs Sorry.. I received the issue messages with one android app these days, and that app didn't display the pic you pasted ahead... so i didn't get what u mean before. |
|
@Yansongsongsong Thanks for your PR, it looks great. |

Description
There is no way to customize the target branch for github uploader. so i add one new text field to check the branch.
I have manually tested it but I dont writes Unit tests for this feature.
This is my first PR in github... so if i have some mistakes in PR process, pls forgive me and tell me how to do that.
thx for your review!
--
Please, don't submit
/distfiles with your PR!