Skip to content

Fix ENOENT error message in CLI#3165

Merged
UziTech merged 10 commits intomarkedjs:masterfrom
rzhade3:fix-error-stderr
Jan 27, 2024
Merged

Fix ENOENT error message in CLI#3165
UziTech merged 10 commits intomarkedjs:masterfrom
rzhade3:fix-error-stderr

Conversation

@rzhade3
Copy link
Copy Markdown
Contributor

@rzhade3 rzhade3 commented Jan 18, 2024

Marked version: 11.1.1

Markdown flavor: n/a

Description

This PR fixes a slight bug in the marked CLI in which the error message due to a ENOENT was bugging out the error output.

I also updated the language in the ENOENT error to better reflect the fact that the ENOENT may have been due to any of the inputted files.

Expectation

When running the marked CLI with an input file that does not exist, I expect it to print out an error containing only the relevant information.

Screenshot 2024-01-18 at 1 58 05 AM

Result

Marked was attempting to print out both error paths, and attempting to print an error object to stderr

Screenshot 2024-01-18 at 1 59 27 AM

What was attempted

The stacktrace above was remediated.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 11:09pm

UziTech
UziTech requested changes Jan 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are failing. Can you also add a test for this so there is no regression in the future?

@rzhade3
Copy link
Copy Markdown
Contributor Author

rzhade3 commented Jan 19, 2024

@UziTech I've fixed the failing tests and attempted to write a test to prevent regressions, but it looked like this part of the code is currently not well tested. I seem to be running into this error whenever I attempt to pass a file as an input to the tests, that I'd appreciate some help debugging:

image

@UziTech
Copy link
Copy Markdown
Member

UziTech commented Jan 21, 2024

looks like the error was in the bin test framework

styfle
styfle reviewed Jan 25, 2024
View reviewed changes
@rzhade3 rzhade3 requested a review from styfle January 25, 2024 20:40
styfle
styfle reviewed Jan 25, 2024
View reviewed changes
@rzhade3 @styfle
Update bin/main.js
16709cf 
Co-authored-by: Steven <steven@ceriously.com>
@rzhade3 rzhade3 requested a review from styfle January 25, 2024 23:13
styfle
styfle approved these changes Jan 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@styfle styfle requested a review from UziTech January 26, 2024 23:06
@UziTech UziTech merged commit bf44ae8 into markedjs:master Jan 27, 2024
github-actions bot pushed a commit that referenced this pull request Jan 27, 2024
@semantic-release-bot
chore(release): 11.2.0 [skip ci]
f0507cb 
# [11.2.0](v11.1.1...v11.2.0) (2024-01-27)

### Bug Fixes

* Fix ENOENT error message in CLI ([#3165](#3165)) ([bf44ae8](bf44ae8))

### Features

* flatten childToken arrays ([#3172](#3172)) ([4826841](4826841))
@mnathsnyk mnathsnyk mentioned this pull request Mar 15, 2024
Open
This was referenced Jun 19, 2024
Open
Closed
@leonardoadame leonardoadame mentioned this pull request Jul 3, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jul 15, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 16, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 25, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jul 26, 2024
Open
@mightysai1997 mightysai1997 mentioned this pull request Jul 31, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@clifford-snyk-github clifford-snyk-github mentioned this pull request Aug 15, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 19, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Aug 19, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Aug 28, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 29, 2024
Open
This was referenced Sep 9, 2024
Open
Open
Open
This was referenced Sep 16, 2024
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 23, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle approved these changes

@UziTech UziTech Awaiting requested review from UziTech

Assignees

@styfle styfle

@calculuschild calculuschild

@joshbruce joshbruce

@davisjam davisjam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rzhade3 @UziTech @styfle @calculuschild @joshbruce @davisjam