Skip to content

feat: add --no-clobber option to CLI#3025

Merged
UziTech merged 4 commits intomarkedjs:masterfrom
skoriop:cli-add-noclobber
Oct 5, 2023
Merged

feat: add --no-clobber option to CLI#3025
UziTech merged 4 commits intomarkedjs:masterfrom
skoriop:cli-add-noclobber

Conversation

@skoriop
Copy link
Copy Markdown
Contributor

@skoriop skoriop commented Oct 3, 2023

Marked version: c9ffa64

Markdown flavor: n/a

Description

If the --no-clobber / -n option is set, it throws an error if the output file already exists.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 8:17pm

Copy link
Copy Markdown
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice to add a test for this one too 👍

Copy link
Copy Markdown
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the option to --no-clobber to be consistent with other commands. https://man7.org/linux/man-pages/man1/cp.1.html

@styfle styfle changed the title Add --noclobber option to CLI feat: add --no-clobber option to CLI Oct 4, 2023
@UziTech UziTech merged commit b8adee7 into markedjs:master Oct 5, 2023
github-actions bot pushed a commit that referenced this pull request Oct 5, 2023
# [9.1.0](v9.0.3...v9.1.0) (2023-10-05)

### Features

* add `--no-clobber` option to CLI ([#3025](#3025)) ([b8adee7](b8adee7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it possible to add a noclobber option?

3 participants