Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
for more information, see https://pre-commit.ci
|
Thanks @yangdanny97! We're happy to review this. If this gets merged, we can document its support in our own docs, but also on Pyrefly docs (here: https://pyrefly.org/en/docs/IDE-features/#notebook-support) — does that sound good to you? |
|
I have read the CLA Document and I hereby sign the CLA |
|
@akshayka hi, thanks! Yep, I'll update Pyrefly's docs once this is merged. I'm still working on debugging the diagnostics. Pyrefly is sending them (I can see it in the lsp logs) but somehow the listener does not pick them up, even if diagnostics box is checked in the user config. All other LSP functionalities work. |
for more information, see https://pre-commit.ci
|
I wonder if there's an issue with my local setup. I can't get diagnostics to appear for basedpyright or ty in my local dev build either, even without the changes in this PR. @winstxnhdw do you remember having to do any sort of special dev setup to test your PRs for bpr/ty, or were the steps in https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md#setup sufficient? |
|
Hey @yangdanny97 I didn't have to do anything special. I did have to restart my setup every time I switch LSPs though. It might be worth looking at the console logs to see if an exception is being thrown. |
|
Demo of some LSP features from building this locally Diagnostics: 
go-to-definition
My config: 
|
|
@yangdanny97, i think the OpenAPI spec is failing. you may need to run |
|
i think there is a failing unrelated test. this looks great, thanks @MarcoGorelli and @yangdanny97 ! |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.11-dev3 |
|
Thanks for the quick review! |
Summary: The "notebook support" section doesn't mention Marimo support, which was added in marimo-team/marimo#7567 . I discussed with mscolnick about adding it to the Pyrefly docs Pull Request resolved: #2545 Reviewed By: grievejia Differential Revision: D94521297 Pulled By: yangdanny97 fbshipit-source-id: 7565b60e15b6a722fd49b33b001850eed9f7eb61
📝 Summary
Similar to recent PRs for ty & basedpyright, this PR adds support for Pyrefly, another fast language server and type checker
I read through the discussion in #1163, and I think that Pyrefly would be a good addition (perhaps falling somewhere between basedpyright & ty on the spectrum of maturity).
It's being used in similar tools like Positron, and is significantly more complete in terms of type system coverage than ty
Diagnostics
🔍 Description of Changes
📋 Checklist