Merged
Conversation
sebr72
reviewed
May 27, 2025
core/src/main/java/org/mapfish/print/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
0456055 to
db527a0
Compare
Contributor
Author
|
I have push the same text comit twice, so you see the changes following your pull request comments. Dont hesitate to squash these commits if you decide to merge this pull request |
lanseg
pushed a commit
that referenced
this pull request
Jun 3, 2025
* Yaml reader is not thread safe * Yaml reader is not thread safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yaml reader in ConfigurationFactory is not thread safe, it can be problematic when 'getConfig' function is called (line 64) with multiple threads as the same time.