New forceFailOnError configuration parameter to set once failOnError for all layers#3623
Merged
sebr72 merged 2 commits intomapfish:masterfrom Jun 24, 2025
Merged
Conversation
9b969b4 to
346ea0e
Compare
sebr72
requested changes
Jun 13, 2025
Contributor
sebr72
left a comment
There was a problem hiding this comment.
Thanks for this enhancement. Mainly minor changes required.
...c/test/java/org/mapfish/print/processor/map/CreateMapPagesForceFailOnErrorProcessorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/mapfish/print/processor/map/CreateMapPagesForceFailOnErrorProcessorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/mapfish/print/processor/map/CreateMapPagesForceFailOnErrorProcessorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/mapfish/print/processor/map/CreateMapPagesForceFailOnErrorProcessorTest.java
Show resolved
Hide resolved
346ea0e to
7e22152
Compare
Contributor
Author
|
I have made the corrections in a separated commit, dont hesitate to squash the commit alltogether, if the PR is good for you |
7e22152 to
546fd97
Compare
Contributor
Author
|
@sebr72 thank you for all the merges, do you know when you will be able to release a new version ? |
Contributor
|
@arnaudboudier-sogelink Release 3.33 in progress. |
lanseg
pushed a commit
that referenced
this pull request
Jul 1, 2025
…for all layers (#3623) * Add forceFailOnError configuration parameter to set failOnError on all layers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new parameter for config, that allow to set failOnError on all layers directly.