Paging: Add an option to add an overview layer to the main map that displays the position of the pages#3618
Merged
sebr72 merged 2 commits intomapfish:masterfrom Jun 23, 2025
Conversation
sbrunner
reviewed
May 5, 2025
examples/src/test/resources/examples/paging_with_overview_layer/config.yaml
Outdated
Show resolved
Hide resolved
737f3fd to
c5e1bf5
Compare
Contributor
Author
|
@sebr72 Have you got some time to check this pull request, I have updated the CreateMapPagesProcessorTest.java to validate this feature |
c5e1bf5 to
1223b58
Compare
sebr72
requested changes
Jun 11, 2025
Contributor
sebr72
left a comment
There was a problem hiding this comment.
Great work. Thanks.
Just a couple of minor changes.
core/src/main/java/org/mapfish/print/processor/map/CreateMapPagesProcessor.java
Show resolved
Hide resolved
examples/src/test/resources/examples/paging_with_overview_layer/README.md
Outdated
Show resolved
Hide resolved
Contributor
|
@sbrunner Concerning the documentation, could you please point out how to add this new feature ? |
1223b58 to
c32264e
Compare
Contributor
Author
|
I made the correction in a second commit, if after your review everything is ok, you can squash the commits together |
sbrunner
reviewed
Jun 12, 2025
Member
sbrunner
left a comment
There was a problem hiding this comment.
For the documentation, you should add your example at two places, the new attributes will appear here: https://mapfish.github.io/mapfish-print-doc/attributes.html#!paging
:-)
core/src/main/java/org/mapfish/print/processor/map/CreateMapPagesProcessor.java
Show resolved
Hide resolved
eefbb70 to
edd10b8
Compare
…map that displays the position of the pages on the main map
edd10b8 to
5242f00
Compare
…map that displays the position of the pages on the main map
5242f00 to
88db4f1
Compare
lanseg
pushed a commit
that referenced
this pull request
Jul 1, 2025
…isplays the position of the pages (#3618) * Feature : paging add an option to add an overview layer to the main map that displays the position of the pages on the main map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows (when using paging options) to add an overview layer that can be stylized to the main map (first page). This overview layer is a grid that display the page number of pages created during paging.
It is usesful to quickly find which portion of the main map correspond to a page.