This repository was archived by the owner on Apr 10, 2018. It is now read-only.
re-add text-translate and icon-translate as style props#83
Merged
Conversation
Member
|
Agreed. |
Member
|
The only thing that may cause confusion is that |
8 tasks
ansis
added a commit
that referenced
this pull request
Jul 8, 2014
re-add text-translate and icon-translate as style props
Closed
This was referenced Aug 21, 2014
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should support icon/text translation both during placement and at render time. Render time translation lets us make shifted shadows. Translation during placement is needed for positioning text relative to icons.
This re-adds
text-translateandicon-translateas style properties (render time translation). It renames the render translate properties totext-offsetandicon-offset. Is there a better name than -offset?@mourner @kkaefer @nickidlugash