Skip to content
This repository was archived by the owner on Apr 10, 2018. It is now read-only.
This repository was archived by the owner on Apr 10, 2018. It is now read-only.

Make "icon-offset" units more intuitive #84

@ansis

Description

@ansis

from #83

The only thing that may cause confusion is that text-offset is in ems, while icon-offset is in pixels. But maybe that's not important.

The current units for icon-offset aren't even exactly pixels. If the icon gets scaled with icon-size then the offset also gets scaled. An icon with "icon-offset": 6 and "icon-size": 0.5 actually has an offset of 3 pixels.

For now the units need to be relative to the unscaled size, not absolute values, but maybe we should changes the units of icon-offset to a fraction of the original size.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions