Skip to content

Add support for circle-stroke-* properties#3672

Merged
lucaswoj merged 2 commits intomasterfrom
circle-stroke
Nov 30, 2016
Merged

Add support for circle-stroke-* properties#3672
lucaswoj merged 2 commits intomasterfrom
circle-stroke

Conversation

@lucaswoj
Copy link
Copy Markdown
Contributor

@lucaswoj lucaswoj commented Nov 22, 2016

actual 5 14 06 pm

This PR adds support for circle-stroke-* properties:

  • circle-stroke-color
  • circle-stroke-width
  • circle-stroke-opacity

All of these support data-driven styling out of the box.

fixes #1713
ref mapbox/mapbox-gl-test-suite#182
ref mapbox/mapbox-gl-style-spec#579
ref mapbox/mapbox-gl-shaders#39

cc @jfirebaugh @mourner @lbud

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp
Copy link
Copy Markdown
Contributor

yesss so excited for this!

@lucaswoj
Copy link
Copy Markdown
Contributor Author

lucaswoj commented Nov 28, 2016

This is ready for 👁 , @jfirebaugh @mourner @lbud

@jfirebaugh
Copy link
Copy Markdown
Contributor

Is there a defined z-order for circles within a layer? It didn't matter before because there was no way to visually distinguish the order. But now there is.

@lucaswoj
Copy link
Copy Markdown
Contributor Author

Is there a defined z-order for circles within a layer? It didn't matter before because there was no way to visually distinguish the order. But now there is.

We render circles, like other non-symbol layers, in the order specified by the source. geojson and vector sources provide an ordered set of features.

Because ordering is more important in symbol layers, we sort them by "y coordinate" then "x coordinate." This would be possible to do for circles layers.

It is possible to visually distinguish the order of patterned fills but I'm not aware of any ordering guarantees for that layer type.

@lucaswoj
Copy link
Copy Markdown
Contributor Author

Updated, squashed, and ready to 🚢 on 🍵 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"circle-stroke-*" style properties

4 participants