This repository was archived by the owner on Apr 10, 2018. It is now read-only.
Add support for circle-stroke-* properties#579
Merged
Conversation
5 tasks
lbud
reviewed
Nov 28, 2016
reference/v8.json
Outdated
| }, | ||
| "circle-stroke-opacity": { | ||
| "type": "number", | ||
| "doc": "The stroke opacity of the circle.", |
Contributor
There was a problem hiding this comment.
This sounds a little funky to me — in my head something like "The opacity of the circle's stroke" might sound better? (but if this sounds fine to other people I am okay with it)
Author
There was a problem hiding this comment.
Agreed. Updated in the latest commit. (Along with some other tweaks).
lbud
approved these changes
Nov 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.