-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Make "icon-offset" units be pixels #4078
Copy link
Copy link
Closed
Labels
api 📝breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Metadata
Metadata
Assignees
Labels
api 📝breaking change ⚠️Requires a backwards-incompatible change to the APIRequires a backwards-incompatible change to the APIcross-platform 📺Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
From @ansis on July 8, 2014 23:26
from #83
The current units for icon-offset aren't even exactly pixels. If the icon gets scaled with icon-size then the offset also gets scaled. An icon with
"icon-offset": 6and"icon-size": 0.5actually has an offset of 3 pixels.For now the units need to be relative to the unscaled size, not absolute values, but maybe we should changes the units of icon-offset to a fraction of the original size.
Copied from original issue: mapbox/mapbox-gl-style-spec#84