Skip to content

VDB-1055 nuke custom transformer#69

Merged
rmulhol merged 4 commits intostagingfrom
vdb-1055-nuke-custom-transformer
Dec 16, 2019
Merged

VDB-1055 nuke custom transformer#69
rmulhol merged 4 commits intostagingfrom
vdb-1055-nuke-custom-transformer

Conversation

@m0ar
Copy link
Copy Markdown
Contributor

@m0ar m0ar commented Dec 16, 2019

omg it's finally happening 🚀 ☢️

Couldn't make myself wait for #67 so I branched off that 😁

@m0ar m0ar self-assigned this Dec 16, 2019
@rmulhol rmulhol force-pushed the vdb-1055-nuke-custom-transformer branch from 68d2da6 to c86b611 Compare December 16, 2019 20:44
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Would be cool to make sure we don't lose the stuff from #73 when this is merged (e.g. remove duplicate db initialization in shared/fk_utils_test.go)

Copy link
Copy Markdown
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@rmulhol rmulhol merged commit 8151d0c into staging Dec 16, 2019
@rmulhol rmulhol deleted the vdb-1055-nuke-custom-transformer branch December 16, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants