Conversation
rmulhol
approved these changes
Dec 16, 2019
Contributor
rmulhol
left a comment
There was a problem hiding this comment.
Nice work - these changes are legit!
Didn't note everywhere goimports -w would help, but other than that my only thought is removing db vars from places where it's not used by the converter.
elizabethengelman
approved these changes
Dec 16, 2019
transformers/test_data/tick.go
Outdated
| }, | ||
| } | ||
|
|
||
| func TickModel() event.InsertionModel { return CopyEventModel(tickModel) } |
ee50798 to
e88ff45
Compare
e88ff45 to
fa9188f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went back to clean up a few previous commits based on more recent feedback
BeforeEachindividual testtest_data/models