Merged
Conversation
Contributor
rmulhol
commented
Aug 21, 2020
- companion PR for changes to vulcanizedb: Vdb 1424 remove hashed addresses vulcanizedb#121
- don't need hashed addresses with Geth version that emits raw address
yaoandrew
approved these changes
Aug 25, 2020
Contributor
yaoandrew
left a comment
There was a problem hiding this comment.
Looks good to me 🚢 . Just had a non-blocking question on some type conversions.
| repository := cat.StorageRepository{ContractAddress: contractAddress.Hex()} | ||
| transformer = storage.Transformer{ | ||
| Address: common.HexToAddress(contractAddress), | ||
| Address: common.HexToAddress(contractAddress.Hex()), |
Contributor
There was a problem hiding this comment.
What type is contractAddress? I'm not sure I follow all the converting here. Isn't it already an address?
8a81a9a to
80fffb3
Compare
- companion PR for changes to vulcanizedb - don't need hashed addresses with Geth version that emits raw address
80fffb3 to
3255917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.