Merged
Conversation
yaoandrew
commented
Aug 11, 2020
bbf2758 to
c1bf259
Compare
rmulhol
reviewed
Aug 12, 2020
rmulhol
left a comment
There was a problem hiding this comment.
Looking good! Will be curious to take one more look after the rebase
| github.com/fjl/memsize v0.0.0-20190710130421-bcb5799ab5e5 // indirect | ||
| github.com/gballet/go-libpcsclite v0.0.0-20191108122812-4678299bea08 // indirect | ||
| github.com/gorilla/websocket v1.4.1 // indirect | ||
| github.com/ethereum/go-ethereum v1.9.8 |
There was a problem hiding this comment.
If we're bumping this, might be cool to bump it even higher - but idk if it matters given the replace below 🤔
elizabethengelman
left a comment
There was a problem hiding this comment.
Looking good!
I'm wondering if some associated changes need to be made to the transformers repo as well - like in configured transformer component tests.
c1bf259 to
b0be075
Compare
rmulhol
approved these changes
Aug 24, 2020
781b86f to
26792e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.