Add support for backfilling urns from fork events#193
Conversation
f4954f9 to
e3a5c8b
Compare
- Get it from a dependency - Compatibility for not exporting HeaderRepository implementation
| "github.com/makerdao/vdb-mcd-transformers/transformers/test_data" | ||
| "github.com/makerdao/vulcanizedb/libraries/shared/factories/event" | ||
| "github.com/makerdao/vulcanizedb/pkg/core" | ||
| "github.com/makerdao/vulcanizedb/pkg/datastore" |
There was a problem hiding this comment.
I made a note in sky-ecosystem/vulcanizedb#96 as well, but I'm not sure I understand the switch to importing datastore when we're also still importing repositories on the line below. Not a big deal, just wanted to understand what's going on! Also, super possible that I'm having "end of the day before a day off brain". ;p
There was a problem hiding this comment.
Yeah the idea is that for the type we import the interface from datastore and then when we initialize we use NewHeaderRepository from repositories, but the actual implementation of headerRepository in repositories is private
| } | ||
| } | ||
|
|
||
| func (retriever dartDinkRetriever) RetrieveDartDinkDiffs(dartDink DartDink) error { |
There was a problem hiding this comment.
This is kind of nitpicky, but RetrieveDartDinkDiff seems like the method will be returning DartDinkDiffs to me, instead of the inserting them. But I'm not sure how else to name this besides going back to FetchAndPersist.... Definitely not merge blocking though!
There was a problem hiding this comment.
Yeah, this was a major struggle for me. I'm honestly just not sure how to name this, but DartDinkFetchAndPersister is where I drew the line 😅
No description provided.