(VDB-1315) Add GetHeaderByID for event-based backfill#96
Merged
Conversation
elizabethengelman
approved these changes
May 26, 2020
| }) | ||
| }) | ||
|
|
||
| Describe("creating a receipt", func() { |
There was a problem hiding this comment.
Is this being removed because we have tests in pkg/datastore/postgres/repositories/receipt_repository_test.go?
| test_config.CleanTestDB(db) | ||
| receiptRepo = repositories.ReceiptRepository{} | ||
| headerRepo = repositories.NewHeaderRepository(db) | ||
| header = core.Header{ |
| "github.com/makerdao/vulcanizedb/pkg/contract_watcher/helpers/test_helpers/mocks" | ||
| "github.com/makerdao/vulcanizedb/pkg/contract_watcher/repository" | ||
| "github.com/makerdao/vulcanizedb/pkg/core" | ||
| "github.com/makerdao/vulcanizedb/pkg/datastore" |
There was a problem hiding this comment.
How come we're importing the HeaderRepository as datastore now instead of repositories? It looks like it's still in the repositories package.
Author
There was a problem hiding this comment.
datastore is the interface, repositories is the (now private) implementation
added 2 commits
May 26, 2020 16:20
- rename previous GetHeader to GetHeaderByBlockNumber
- Access via interface not implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.