Don't build WASM extensions by jwendell · Pull Request #253 · maistra/proxy

jwendell · 2023-08-17T15:48:41Z

We are not building them in product anyway.

Plus, by not using the python dependencies we are able to build for arm64.

openshift-ci · 2023-08-17T15:48:45Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jwendell · 2023-08-17T15:49:07Z

/test all

jwendell · 2023-08-17T16:11:03Z

/test all

yxun · 2023-08-21T20:55:49Z

We are not building them in product anyway.

Plus, by not using the python dependencies we are able to build for arm64.

curious, are we only using python dependencies for building WASM extension in proxy ? There is also a section of python dependencies from istio builder image side.

jwendell · 2023-08-21T20:57:05Z

yes, only for wasm. This is proxy build. It has nothing to do with istio builds.

Since maistra/proxy#253

Signed-off-by: Ted Poole <tpoole@redhat.com>

Since maistra/proxy#253

* Do not rely on WASM extensions Since maistra/proxy#253 * Remove wasm extensions from EnvoyFilters Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Disable tests for WASM extensions Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Remove commented code Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Jonh Wendell <jwendell@redhat.com>

* OSSM-2378: Use Maistra proxy CentOS Stream 8 img (#713) * OSSM-2378: Use Maistra proxy CentOS Stream 8 img For integration tests. Based on (#609) * Build container images with docker Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Use maistra proxy and CentOS Stream 8 as a base image for proxyv2 Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Test VMs using CentOS Stream 8 Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Temporarily skip failing security tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Temporarily skip tests suite telemetry.prometheus.wasm Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * fix(tests): enables fixed integration tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> * Use our proxy (#801) Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * OSSM-5958: Remove wasm extensions (#937) * Do not rely on WASM extensions Since maistra/proxy#253 * Remove wasm extensions from EnvoyFilters Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Disable tests for WASM extensions Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Remove commented code Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Jonh Wendell <jwendell@redhat.com> * Disable failing tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Fix TestTrustDomainValidation - change expected TLS error to make it work with OpenSSL Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> Co-authored-by: Jonh Wendell <jwendell@redhat.com>

* OSSM-2378: Use Maistra proxy CentOS Stream 8 img (maistra#713) * OSSM-2378: Use Maistra proxy CentOS Stream 8 img For integration tests. Based on (maistra#609) * Build container images with docker Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Use maistra proxy and CentOS Stream 8 as a base image for proxyv2 Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Test VMs using CentOS Stream 8 Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Temporarily skip failing security tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Temporarily skip tests suite telemetry.prometheus.wasm Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * fix(tests): enables fixed integration tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Jacek Ewertowski <jewertow@redhat.com> * Use our proxy (maistra#801) Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * OSSM-5958: Remove wasm extensions (maistra#937) * Do not rely on WASM extensions Since maistra/proxy#253 * Remove wasm extensions from EnvoyFilters Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Disable tests for WASM extensions Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Remove commented code Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Jonh Wendell <jwendell@redhat.com> * Disable failing tests Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> * Fix TestTrustDomainValidation - change expected TLS error to make it work with OpenSSL Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> --------- Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Jonh Wendell <jonh.wendell@redhat.com> Co-authored-by: Jonh Wendell <jwendell@redhat.com>

Don't build WASM extensions

c8117f8

openshift-ci bot added the do-not-merge/work-in-progress label Aug 17, 2023

openshift-ci bot added the size/M label Aug 17, 2023

jwendell marked this pull request as ready for review August 21, 2023 20:41

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 21, 2023

yxun approved these changes Aug 21, 2023

View reviewed changes

jwendell added the okay to merge label Aug 21, 2023

openshift-merge-robot merged commit 62b15c0 into maistra:maistra-2.4 Aug 21, 2023

jwendell added a commit to jwendell/istio-maistra that referenced this pull request Aug 22, 2023

Do not rely on WASM extensions

3204ac2

Since maistra/proxy#253

jwendell mentioned this pull request Aug 22, 2023

Do not rely on WASM extensions maistra/istio#839

Closed

jwendell added a commit to jwendell/istio-maistra that referenced this pull request Aug 23, 2023

Do not rely on WASM extensions

8e7b118

Since maistra/proxy#253

tedjpoole pushed a commit to tedjpoole/maistra-proxy that referenced this pull request Nov 8, 2023

Don't build WASM extensions (maistra#253)

b034dcf

Signed-off-by: Ted Poole <tpoole@redhat.com>

jewertow pushed a commit to jewertow/istio that referenced this pull request Feb 19, 2024

Do not rely on WASM extensions

392123d

Since maistra/proxy#253

jewertow mentioned this pull request Feb 19, 2024

OSSM-5958: Remove wasm extensions maistra/istio#937

Merged

yxun mentioned this pull request May 22, 2024

[maistra-2.6] Rebase building OpenSSL-based proxy image maistra/istio#1008

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't build WASM extensions#253

Don't build WASM extensions#253
openshift-merge-robot merged 1 commit intomaistra:maistra-2.4from
jwendell:disable-wasm

jwendell commented Aug 17, 2023 •

edited

Loading

Uh oh!

openshift-ci bot commented Aug 17, 2023

Uh oh!

jwendell commented Aug 17, 2023

Uh oh!

jwendell commented Aug 17, 2023

Uh oh!

yxun commented Aug 21, 2023

Uh oh!

jwendell commented Aug 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jwendell commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 17, 2023

Uh oh!

jwendell commented Aug 17, 2023

Uh oh!

jwendell commented Aug 17, 2023

Uh oh!

yxun commented Aug 21, 2023

Uh oh!

jwendell commented Aug 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jwendell commented Aug 17, 2023 •

edited

Loading