Skip to content

Fix message id for Postfix in Message Operations#1

Closed
endelwar wants to merge 17 commits intomailwatch:masterfrom
endelwar:master
Closed

Fix message id for Postfix in Message Operations#1
endelwar wants to merge 17 commits intomailwatch:masterfrom
endelwar:master

Conversation

@endelwar
Copy link
Copy Markdown
Member

Mailscanner adds a dot and a 5 digit random number to Postfix message id; this message id is used in Message Operations as variable names in radio buttons, but PHP doesn't allow dots (.) in variable names and changes them with underscore (_) [http://php.net/manual/en/language.variables.external.php].
This fix checks if $mta is Postfix and changes back underscores to dots making Message Operations works.

Mailscanner adds a dot and a 5 digit random number to Postfix message id; this message id is used in Message Operations as variable names in radio buttons, but PHP doesn't allow dots (.) in variable names and changes them with underscore (_) [http://php.net/manual/en/language.variables.external.php].
This fix checks if $mta is Postfix and changes back underscores to dots making Message Operations works.
This commit removes all trailing PHP closing tags ("?>") and extra new
lines; it also add some missing semicolons.
This commit removes the W3C and SourceForge logos from page footer,
making page load faster because of the removed connection to two
external server (http://www.w3.org/Icons/valid-html401 and
http://sflogo.sourceforge.net/sflogo.php?group_id=87163&type=10).
Removing SourceForge logo removes also user tracking by SourceForge.
If MTA stats are empty some errors appear in rep_total_mail_by_date.php
Fixes a Local File Inclusion security bug, marked as CVE-2008-5991
To remove "BETA 4" subdir: version tagging can be done using git-tag commanf
@askewdread
Copy link
Copy Markdown
Contributor

Have added manually, this was being stupid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants