This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Update zendframework/zend-code#101
Merged
buskamuza merged 1 commit intomagento-engcom:libs-upgradefrom Apr 6, 2018
Merged
Conversation
- Update `zendframework/zend-code` to `~3.3.0`
Contributor
Author
|
The Travis build came back with some errors in generation. I will review these and see if they are significant, or whether we can just update the tests. (For only whitespace, and other syntactically insignificant changes.) |
Contributor
|
One difference that I observed is a difference in arrays representation: |
4 tasks
buskamuza
added a commit
that referenced
this pull request
Apr 6, 2018
Update `zendframework/zend-code`
magento-engcom-team
added a commit
that referenced
this pull request
Jul 19, 2018
- Merge Pull Request magento/graphql-ce#101 from magento/graphql-ce:category-fragment-fix - Merged commits: 1. 284f345 2. 6c8f256
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zendframework/zend-codeto~3.3.0Description
As per the issue (#93), update the dependency on
zendframework/zend-codeto~3.3.0.Fixed Issues (if relevant)
zendframework/zend-codeManual testing scenarios
Shouldn't be any testing required. The site still seems to function normally, but all tests should run to check for regressions.
Contribution checklist