Cron uses the wrong timestamp method#9943
Merged
magento-team merged 2 commits intomagento:developfrom Jun 16, 2017
Merged
Conversation
added 2 commits
June 14, 2017 14:47
Because the cron job uses a localized timestamp instead of a regular timestamp, all times in the cron_schedule table are not the actual times, but times with a double offset. By using the regular timestamp, all times in cron_schedule are correct. The cron job execution times are not affected by this change because schedule generation and job execution depend on the same timestamp. If both are in the same timezone all will go as intended. Fixes magento#4237
magento-team
pushed a commit
that referenced
this pull request
Jun 16, 2017
ktomk
added a commit
to netz98/n98-magerun2
that referenced
this pull request
Jun 16, 2017
Since Magento 2.2.0 the cron database tables will use GMT timestamps, before that version Magento has used timestamps in a different timezone. Fix is to branch based on Magento version: a) Use GMT timestamps from version 2.2.0 or above. b) Use local timestamps up to version 2.2.0 Refs: - Command: sys:cron:run - Command: sys:cron:schedule - #296 - magento/magento2#9943
cmuench
pushed a commit
to cmuench/n98-magerun2
that referenced
this pull request
Oct 11, 2017
Since Magento 2.2.0 the cron database tables will use GMT timestamps, before that version Magento has used timestamps in a different timezone. Fix is to branch based on Magento version: a) Use GMT timestamps from version 2.2.0 or above. b) Use local timestamps up to version 2.2.0 Refs: - Command: sys:cron:run - Command: sys:cron:schedule - #296 - magento/magento2#9943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because the cron job uses a localized timestamp instead of a regular
timestamp, all times in the cron_schedule table are not the actual
times, but times with a double offset.
By using the regular timestamp, all times in cron_schedule are correct.
The cron job execution times are not affected by this change because
schedule generation and job execution depend on the same timestamp.
If both are in the same timezone all will go as intended.
Fixes #4237
Fixed Issues (if relevant)
Manual testing scenarios
bin/magento cron:runbin/magento cron:runagainContribution checklist