By default, show times in admin grids in the store timezone.#9941
Merged
magento-team merged 1 commit intomagento:developfrom Jun 16, 2017
Merged
By default, show times in admin grids in the store timezone.#9941magento-team merged 1 commit intomagento:developfrom
magento-team merged 1 commit intomagento:developfrom
Conversation
fixes magento#9426 This test basically said, use the column config value, or use FALSE: $timezone = isset($this->getConfiguration()['timezone']) ? $this->booleanUtils->convert($this->getConfiguration()['timezone']) : false; The only config values currently present in the code set the 'timezone' config to FALSE using `<timezone>false</timezone>`. There are 0 occurances of `<timezone>true</timezone>` in the code base at this time. This makes me believe that the default value should not be FALSE but TRUE. Otherwise the outcome will always be FALSE, be it explicit or by default. This way the product review created_at times will be the same in the catalog/product/edit adminhtml page as well as on the Marketing | Reviews grid. They were not equal before this commit. The same goes for the CMS page grid, the CMS block grid, the customer grid, the online customers grid, and the sales grids. I believe admins wint to see these times in their configured time zone and not in UTC. Otherwise someone can appear to have placed an order in the future which is very confusing.
magento-team
pushed a commit
that referenced
this pull request
Jun 16, 2017
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 16, 2025
[Bluetooth] Community Pull Requests delivery - Dec comprs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #9426
This test basically said, use the column config value, or use FALSE:
The only config values currently present in the code set the 'timezone'
config to FALSE using
<timezone>false</timezone>. There are 0 occurancesof
<timezone>true</timezone>in the code base at this time. This makesme believe that the default value should not be FALSE but TRUE. Otherwise
the outcome will always be FALSE, be it explicit or by default.
This way the product review created_at times will be the same in the
catalog/product/edit adminhtml page as well as on the Marketing | Reviews
grid. They were not equal before this commit.
The same goes for the CMS page grid, the CMS block grid, the customer grid,
the online customers grid, and the sales grids.
I believe admins wint to see these times in their configured time zone and
not in UTC. Otherwise someone can appear to have placed an order in the
future which is very confusing.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist