Skip to content

Ability to add Translation for CMS page and CMS block. Added translation as a custom variable. #164#506

Closed
miguelbalparda wants to merge 4 commits intomagento:masterfrom
miguelbalparda:master
Closed

Ability to add Translation for CMS page and CMS block. Added translation as a custom variable. #164#506
miguelbalparda wants to merge 4 commits intomagento:masterfrom
miguelbalparda:master

Conversation

@miguelbalparda
Copy link
Copy Markdown
Contributor

Translate CMS Pages in Magento.

Use: In any CMS Page or Block use {{translate text="Text here"}} and the text will be translatable with the Inline translator.

Also available as custom variable:
translation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed double call to $this->_objectManager->create('Magento\Core\Model\Variable') and changed name of var to variablesModel instead of variables.

@tanya-soroka
Copy link
Copy Markdown

Hello @miguelbalparda, thank you for submit this suggestion!
We have already discussed this improvement and added to our product backlog.
We will review your code changes and provide our feedback.

@miguelbalparda
Copy link
Copy Markdown
Contributor Author

Thank you @tanya-soroka! I will add 2 more comments tomorrow to clarify my code so its easy to re use.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$optionArray[] may be be used as $optionArray

@tanya-soroka
Copy link
Copy Markdown

Hello @miguelbalparda. Thank your submission.
We are going to make additional changes in the scope of the i18n implementation, so your request will be added after changes complete. Due to other priorities, it is unlikely that we will be able to include it in the initial Magento 2.0 release, but we will consider it for a follow-on release.

Thank you for your

@maksek
Copy link
Copy Markdown
Contributor

maksek commented Dec 26, 2014

Hi @miguelbalparda, thank you for you contribution. Can you please review the PR and resubmit it with latest code into develop branch. Thanks you.

@miguelbalparda
Copy link
Copy Markdown
Contributor Author

Done @maksek, see #875

magento-team pushed a commit that referenced this pull request Apr 3, 2016
magento-engcom-team added a commit that referenced this pull request Mar 26, 2019
 - Merge Pull Request magento/graphql-ce#506 from XxXgeoXxX/graphql-ce:2.3-develop#498
 - Merged commits:
   1. ef3cc36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants