Skip to content

source item management#36

Merged
naydav merged 2 commits intomagento:source-item-managementfrom
jonfres:source-item-management
Jun 30, 2017
Merged

source item management#36
naydav merged 2 commits intomagento:source-item-managementfrom
jonfres:source-item-management

Conversation

@kieronthomas
Copy link
Copy Markdown
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Valeriy Nayda and others added 2 commits June 23, 2017 15:22
…i-lars

work on region fields, system configuration of default carriers
class SourceItem extends AbstractExtensibleModel implements SourceItemInterface
{
/**
* @return int
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sku int ? is string

}

/**
* @return int
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status int? bool will better if true or false

}

/**
* @param SourceItemInterface $sourceItem
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inheritdoc documentation must define in the interface

throw new CouldNotSaveException(__('Could not save source item'), $e);
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Docblock

return $sourceItem;
}

public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCriteria = null)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be implemented


}

public function delete($sourceItemId)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be implemented

@naydav naydav changed the base branch from develop to source-item-management June 30, 2017 10:25
@naydav naydav merged commit b27c53b into magento:source-item-management Jun 30, 2017
engcom-Golf pushed a commit to engcom-Golf/inventory that referenced this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants