Skip to content

WIP MSI: 288 Add Support For SourceCode into the SourceInterface and SourceItemInterface#298

Merged
maghamed merged 5 commits intodevelopfrom
task-288-add-source-code
Dec 13, 2017
Merged

WIP MSI: 288 Add Support For SourceCode into the SourceInterface and SourceItemInterface#298
maghamed merged 5 commits intodevelopfrom
task-288-add-source-code

Conversation

@larsroettig
Copy link
Copy Markdown
Member

@larsroettig larsroettig commented Dec 13, 2017

  • Add Source code to interface and implementation code
  • Implement Valdition for Source code
  • Add Field to intigration tests

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

larsroettig added 3 commits December 13, 2017 11:43
WIP MSI: #288
3888eca 
- Add Source code to interface and implementation code
- Implement Valdition for Source code
- Add Field to intigration tests
WIP MSI: #288
b224061 
- phpcs fix
WIP MSI: #288
47a9573 
- Add CodeValidator unit test
@larsroettig larsroettig changed the title WIP MSI: #288 WIP MSI: 288 Add Support For SourceCode into the SourceInterface and SourceItemInterface Dec 13, 2017
larsroettig added 2 commits December 13, 2017 16:33
WIP MSI: #288
bdd35c7 
- Bugfixes for Intigrationstests
- Add Index to code field
WIP MSI: #288
6c9800b 
- Fixes for travis
@maghamed maghamed merged commit 37aa67d into develop Dec 13, 2017
@maghamed maghamed deleted the task-288-add-source-code branch December 11, 2018 18:18
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 12, 2023
@jilu1
Merge pull request #298 from magento-gl/ACQE-4368
468372c 
ACQE-3468: Test Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@larsroettig larsroettig

Labels

Award: complex Award: special achievement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larsroettig @maghamed @magento-engcom-team