Merged
Conversation
…rce assignments have been changed
…MSI-invalidate-stockItem-indexes # Conflicts: # app/code/Magento/Inventory/Indexer/StockItem/Mview/Action.php # app/code/Magento/Inventory/Indexer/StockItem/StockItem.php # app/code/Magento/Inventory/etc/di.xml # app/code/Magento/Inventory/etc/mview.xml
…MSI-invalidate-stockItem-indexes # Conflicts: # app/code/Magento/Inventory/Indexer/StockItem/Mview/Action.php # app/code/Magento/Inventory/Indexer/StockItem/StockItem.php # app/code/Magento/Inventory/etc/di.xml # app/code/Magento/Inventory/etc/mview.xml
…rce assignments have been changed
…rce assignments have been changed
…rce assignments have been changed - add integration test for 3 indexers - change logic during testing - disable trigger for stock_item MVIEW by default
larsroettig
reviewed
Oct 23, 2017
Member
larsroettig
left a comment
There was a problem hiding this comment.
Looks good pls add only the static typing
| @@ -0,0 +1,100 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
Please add static PHP static typing to all files
declare(strict_types=1);
…rce assignments have been changed - add ability to hiding indexers
…MSI-invalidate-stockItem-indexes-v2 # Conflicts: # app/code/Magento/Inventory/Test/Integration/Indexer/IndexationTest.php
…rce assignments have been changed - revert ability to hiding indexers
added 5 commits
November 20, 2017 13:23
-- refactoring
-- refactoring
-- refactoring
…ckItem-indexes-v2
-- refactoring
added 2 commits
November 20, 2017 18:28
-- builds fixing
-- builds fixing
| * @param array $conditions | ||
| * @return \ArrayIterator|\Magento\Framework\DB\Select | ||
| */ | ||
| private function prepareSelect($stockId, array $conditions = []) |
Contributor
There was a problem hiding this comment.
Please add type hints to the method declaration
|
|
||
| if (count($skuList) !== 0) { | ||
| $select->where('source_item.' . SourceItemInterface::SKU . ' IN (?)', $skuList); | ||
| if (!empty($conditions)) { |
Contributor
There was a problem hiding this comment.
!empty seems to be redundant here
| * | ||
| * @param int $stockId | ||
| * @param array $conditions | ||
| * @return \ArrayIterator|\Magento\Framework\DB\Select |
Contributor
There was a problem hiding this comment.
It would be much more "defensive" to return just one of the types
This was referenced Nov 22, 2017
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 1, 2021
L3 pr 20210830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Plugins to invalidate StockItem indexes when Stock-to-Source assignments have been changed
Description
Create Plugins to invalidate StockItem indexes when Stock-to-Source assignments have been changed
Fixed Issues (if relevant)
Contribution checklist