Improve error message on wrong type of mg.Deps argument (#240) #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good, but can you write a test for it? Can be pretty simple, just something that'll break if we change the number of function calls between the name and the error? |
This change adds a location of mg.Deps invocation, shrinking the search space from "all your build scripts" to "this particular mg.Deps invocation"
Contributor
Author
|
Sure, added a test. |
Member
|
hmm probably some problem on tip from go modules, I'll look into it. |
Contributor
Author
|
Yes, I saw this test failing with modules. |
mojzesh
pushed a commit
to mojzesh/mage
that referenced
this pull request
Oct 12, 2019
magefile#241) This change adds a location of mg.Deps invocation, shrinking the search space from "all your build scripts" to "this particular mg.Deps invocation"
mojzesh
pushed a commit
to mojzesh/mage
that referenced
this pull request
Oct 12, 2019
magefile#241) This change adds a location of mg.Deps invocation, shrinking the search space from "all your build scripts" to "this particular mg.Deps invocation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a location of mg.Deps invocation, shrinking the search space
from "all your build scripts" to "this particular mg.Deps invocation"