Add mage flags to the compiled mage binary (#180) #199
Conversation
Adding following flags: * -v (verbose) * -l (list) * -h (help) * -t (timeout) * -ignoredefault fixes #180
|
Hmm, that travis-ci build is certainly strange. |
|
Thanks very much for this PR! I'll take a look tonight. Not sure what's going on with the test... it's very weird that it works on 1.10+ and not on 1.9- ... I wouldn't think that would change how the permissions on a temp file are created |
| flag.Parse() | ||
| args.Args = flag.Args() | ||
| // With golangs flag package we can't distinguish, whether a flag's default value has been: | ||
| // * provided by the user or |
There was a problem hiding this comment.
So, the way to do the defaults to environment variables is that when you declare the default up above, instead of hard coding the default to false, get the environment variable's value, and use that as the default.
|
I am working on some updates to this PR, will push them when they're done, then hopefully the build error will go away. |
|
Hope you don't mind, I tweaked it just a bit... removed the ignoredefault flag (it's basically the same as -l). I also made a custom help usage output, because I'm picky. Thanks super much for getting this done, and twice as much for the tests, that's just amazing. |
|
merged in #201. Thanks! |
|
BTW, seems like the build problem was that you can't execute files from the temp directory on more closely secured linux environments, which Travis uses. I'm not exactly sure how Go 1.10 changes the behavior, but I saw some issues about it in the go repo. |
Adding following flags:
fixes #180