Conversation
- cygwin uses GCC windres syntax - cygwin doesn't have _wopen and hence we omit WIDECHAR
d307fa4 to
32d6d9b
Compare
|
I rebased, this fix is currently still valid and needed. Sadly it seems that pull requests here get ignored. I'll try to reach the correct contribution channel e.g. mailing list. |
|
@julianoes I wrote a mail to the developers:
|
|
I'm closing this since there seems to be no maintenance going on since 2017. Pity, I hoped the developer would come back or hand it over to another maintainer. |
|
It looks like there is a maintained fork by chromium but not on GitHub unfortunately. |
|
@MaEtUgR: Any news with Zlib 1.3.1? |
I wanted to build DroneCore a new SDK for autonomous PX4 drones inside my up to date cygwin64 (Windows 10) setup. zlib is one of the dependencies of DroneCore and the one that made the build fail.
Looking at the Problem I found:
(this problem is already fixed on develop and was skipped by git when I cherry-picked)
As Cygwin should be supported according to the documentation I though I might contribute my findings to the develop branch such that they are available in the next release.
With this pr the build works fine and I checked
./examplehas the expected output:closes #238 #248 #268
FYI @madler @julianoes