Add vc15 build files to contrib/vstudio.#270
Conversation
Update path to bld_ml64.bat in x64/DEBUG and remove Safe Exception Handling in Win32/DEBUG
|
See also #243. |
|
Thanks
From: tbeu [mailto:notifications@github.com]
Sent: Tuesday, August 15, 2017 12:27 PM
To: madler/zlib <zlib@noreply.github.com>
Cc: Dmitry Savelev <dv-sav@hotmail.com>; Author <author@noreply.github.com>
Subject: Re: [madler/zlib] Add vc15 build files to contrib/vstudio. (#270)
See also #243<#243>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#270 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOTWUdrZ6sDMLr5-i_ER9CTjwzxAlSkvks5sYUhBgaJpZM4OLmWl>.
|
|
The project already has cmake support. Why would one check in static MSVC project files when you can have cmake generate them for you, for whichever version of Visual Studio that you have? |
To have all the nice features of static VS project files, e.g., multi-configuration, search, manual adaption of settings etc. |
|
You can keep your search files around and regenerate project files from cmake. |
|
It's good that you can also build configurations with CMake. But a VC project file can be built directly with MSBuild without even opening VS, no need to manually create configurations first, it can be opened in VS with all files nicely organized, it can be debugged more easily. So why can't we just merge this? It won't prevent anyone from using CMake. |
|
Author of this repo has been /afk for 2 years, so not sure anything's going to happen. |
|
Oh I see, that's too bad... |
|
It's not correct, see the development in devel branch. But AFAIK contrib/ directory is not supported, see the README. |
|
Well then @madler has the GitHub site configured incorrectly, as all the pull requests are targeting master and not develop. |
|
@praiskup We don't want support, the files there work correctly. We'd just like to add one more build file for latest VS version... |
|
Deleting Visual Studio projects. |
I've added vc15 build fileles and tested the result with Visual Studio 2017 professional (Windows 10 and SDK 10.0.15063.0). Also I've added brebuild steps to zlibstat project (Release x64/Win32 configurations) to compile assembler files there.