CMake: GNUInstallDirs, export target zlib::zlib, CPack configuration, install PDB file#148
Closed
rickertm wants to merge 5 commits intomadler:developfrom
Closed
CMake: GNUInstallDirs, export target zlib::zlib, CPack configuration, install PDB file#148rickertm wants to merge 5 commits intomadler:developfrom
rickertm wants to merge 5 commits intomadler:developfrom
Conversation
|
Very nice - modern buildfiles! Thanks a lot, @rickertm ! Are you sure about the CMake minimum version? I see Not sure when @madler last looked at CMake, but guessing from version 2.4 that might have been a while ago. As a clue on what this is about, just in case: |
…get_include_directories()
Author
|
Thanks for the feedback. You're right, it should be 2.8.11, I was only checking for GNUInstallDirs. Besides target_include_directories(), the module CMakePackageConfigHelpers also needs 2.8.8. |
hzhuang1
pushed a commit
to Linaro/warpdrive-zlib
that referenced
this pull request
Jul 31, 2019
Rename library when compiled without --zlib-compat
Closed
Closed
Owner
|
See #1027 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GNUInstallDirs (${CMAKE_INSTALL_LIBDIR} instead of ${CMAKE_INSTALL_PREFIX}/lib) for improved platform compatibility
Export target zlib::zlib with corresponding config file
Add CPack configuration for packaging
Install PDB file with debug information for Debug and RelWithDebInfo builds